Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2066, land that first
Depends on npm/libnpmpublish#16, land that and publish before landing this patch. Swap
TEMP:
commit for one that upgrades to the new semver-major version of libnpmpublish.Support publishing any kind of spec, not just directories. Also removes the double-pack that we were doing (which isn't horrible, but is a bit less efficient than it could be, of course.)
Improved tests to properly throw when the
publish()
command raises an error, and ensure that it gets all the way to the callback each time.